accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #159: ACCUMULO-1280: many changes for closing iterator...
Date Thu, 20 Oct 2016 17:16:02 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/159#discussion_r84332426
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java ---
    @@ -163,15 +163,15 @@ private static Path createTmpDir(AccumuloConfiguration acuConf,
VolumeManager fs
             try {
               if (reader != null)
                 reader.close();
    -        } catch (IOException e) {
    +        } catch (Exception e) {
    --- End diff --
    
    Should these just catch RuntimeException, then? Or does this reader still throw checked
exceptions, too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message