accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #159: ACCUMULO-1280: many changes for closing iterator...
Date Mon, 17 Oct 2016 22:00:36 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/159#discussion_r83739144
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java ---
    @@ -1164,11 +1167,7 @@ private Reader(Reader r, boolean useSample) {
     
         private void closeLocalityGroupReaders() {
           for (LocalityGroupReader lgr : currentReaders) {
    -        try {
    -          lgr.close();
    -        } catch (IOException e) {
    -          log.warn("Errored out attempting to close LocalityGroupReader.", e);
    -        }
    +        lgr.close();
    --- End diff --
    
    If `currentReaders` were changed to an ArrayList, this could use the stream `forEach`.
Not sure if that would impact performance, but it'd probably improve readability in a few
places.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message