accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #163: ACCUMULO-2278 Return value from in.read() should...
Date Wed, 12 Oct 2016 20:04:56 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/163#discussion_r83087033
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/security/crypto/NonCachingSecretKeyEncryptionStrategy.java
---
    @@ -81,7 +81,10 @@ private void doKeyEncryptionOperation(int encryptionMode, CryptoModuleParameters
           Cipher cipher = DefaultCryptoModuleUtils.getCipher(params.getAllOptions().get(Property.CRYPTO_DEFAULT_KEY_STRATEGY_CIPHER_SUITE.getKey()));
     
           try {
    -        cipher.init(encryptionMode, new SecretKeySpec(keyEncryptionKey, params.getAlgorithmName()));
    +    	if (keyEncryptionKey.length > 0)
    --- End diff --
    
    > The SecretKeySpec constructor would throw IllegalArgumentException
    
    > adding this check probably caused the rest of the code to be executed resulting in
a null exception in another part of the code.
    
    Sounds to me like we would want to throw our own IllegalArgumentException (or some unchecked
exception) in an `else` branch to the conditional you added. Care to update the pull request
with that change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message