accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo issue #162: ACCUMULO-4494 Add families and inclusive to IteratorTes...
Date Sat, 08 Oct 2016 19:17:23 GMT
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/162
  
    >  By default the families is empty and inclusive is false,
    so no existing code should break.
    
    Agreed.
    
    > I would also like to make the helper methods in all the test case classes (such as
IsolatedDeepCopiesTestCase) private.
    
    I think this is fine. Users running the framework shouldn't be looking inside the test
cases. This is also outside of public API (which should be corrected...).
    
    Thanks for putting this together @dhutchis. Let me express my enthusiasm by committing
for you :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message