accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phrocker <...@git.apache.org>
Subject [GitHub] accumulo pull request #161: ACCUMULO-4453 Remove constructor code duplicatio...
Date Thu, 06 Oct 2016 23:19:52 GMT
Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/161#discussion_r82305029
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java
---
    @@ -74,32 +74,26 @@
     
       ScanDataSource(Tablet tablet, Authorizations authorizations, byte[] defaultLabels,
HashSet<Column> columnSet, List<IterInfo> ssiList,
           Map<String,Map<String,String>> ssio, AtomicBoolean interruptFlag, SamplerConfiguration
samplerConfig, long batchTimeOut, String context) {
    -    this.tablet = tablet;
    -    expectedDeletionCount = tablet.getDataSourceDeletions();
    -    this.options = new ScanOptions(-1, authorizations, defaultLabels, columnSet, ssiList,
ssio, interruptFlag, false, samplerConfig, batchTimeOut, context);
    -    this.interruptFlag = interruptFlag;
    -    this.loadIters = true;
    -    log.debug("new scan data source, tablet: {}, options: {}, interruptFlag: {}, loadIterators:
{}", this.tablet, this.options, this.interruptFlag,
    -        this.loadIters);
    +    this(tablet, tablet.getDataSourceDeletions(), new ScanOptions(-1, authorizations,
defaultLabels, columnSet, ssiList, ssio, interruptFlag, false,
    +        samplerConfig, batchTimeOut, context), interruptFlag, true);
       }
     
       ScanDataSource(Tablet tablet, ScanOptions options) {
    -    this.tablet = tablet;
    -    expectedDeletionCount = tablet.getDataSourceDeletions();
    -    this.options = options;
    -    this.interruptFlag = options.getInterruptFlag();
    -    this.loadIters = true;
    -    log.debug("new scan data source, tablet: {}, options: {}, interruptFlag: {}, loadIterators:
{}", this.tablet, this.options, this.interruptFlag,
    -        this.loadIters);
    +    this(tablet, tablet.getDataSourceDeletions(), options, options.getInterruptFlag(),
true);
       }
     
       ScanDataSource(Tablet tablet, Authorizations authorizations, byte[] defaultLabels,
AtomicBoolean iFlag) {
    +    this(tablet, tablet.getDataSourceDeletions(), new ScanOptions(-1, authorizations,
defaultLabels, EMPTY_COLS, null, null, iFlag, false, null, -1, null),
    --- End diff --
    
    it's unrelated but would it make sense to have a constructor for scan options that accepts
only the configurable arguments in this ScanDataSource constructor? Other than this line it
seems fine. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message