Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 78DA4200B82 for ; Fri, 16 Sep 2016 18:24:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 77694160AC4; Fri, 16 Sep 2016 16:24:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BC3FE160AB7 for ; Fri, 16 Sep 2016 18:24:14 +0200 (CEST) Received: (qmail 70153 invoked by uid 500); 16 Sep 2016 16:24:13 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 70138 invoked by uid 99); 16 Sep 2016 16:24:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Sep 2016 16:24:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 747EF2D3BA1; Fri, 16 Sep 2016 16:24:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2803896585008154420==" MIME-Version: 1.0 Subject: Re: Review Request 51933: Improved BlockCache eviction policy From: Josh Elser To: Josh Elser , keith@deenlo.com Cc: Ben Manes , accumulo Date: Fri, 16 Sep 2016 16:24:11 -0000 Message-ID: <20160916162411.31231.45963@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Josh Elser X-ReviewGroup: accumulo X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51933/ X-Sender: Josh Elser References: <20160916011649.31230.64765@reviews.apache.org> In-Reply-To: <20160916011649.31230.64765@reviews.apache.org> X-ReviewBoard-Diff-For: core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/TinyLfuBlockCache.java Reply-To: Josh Elser X-ReviewRequest-Repository: accumulo archived-at: Fri, 16 Sep 2016 16:24:15 -0000 --===============2803896585008154420== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 16, 2016, 1:16 a.m., Ben Manes wrote: > > core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/TinyLfuBlockCache.java, line 64 > > > > > > Thanks. I called the class CaffeinatedBlockCache in HBase, but when porting thought using the policy name was cleaner. I'll fix the HBase patch as well. Thanks, Ben! Let me poke Keith over on JIRA. Otherwise, I'm content to merge this in today. - Josh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51933/#review149160 ----------------------------------------------------------- On Sept. 16, 2016, 1:15 a.m., Ben Manes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51933/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2016, 1:15 a.m.) > > > Review request for accumulo, Josh Elser and kturner. > > > Bugs: ACCUMULO-4177 > https://issues.apache.org/jira/browse/ACCUMULO-4177 > > > Repository: accumulo > > > Description > ------- > > TinyLFU-based BlockCache. > > Algorithmic details provided in, > http://highscalability.com/blog/2016/1/25/design-of-a-modern-cache.html > > > Diffs > ----- > > core/pom.xml 44afddb > core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java 4dfba68 > core/src/main/java/org/apache/accumulo/core/conf/Property.java ede1c6f > core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCache.java 094782d > core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/LruBlockCache.java 1beaccb > core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/TinyLfuBlockCache.java PRE-CREATION > minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java 8e35705 > pom.xml 54e4a72 > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 7751681 > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java 089bd12 > > Diff: https://reviews.apache.org/r/51933/diff/ > > > Testing > ------- > > Basic build > > > Thanks, > > Ben Manes > > --===============2803896585008154420==--