Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: milleruntime <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-151-accumulo@git.apache.org>
In-Reply-To: <git-pr-151-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #151: ACCUMULO-3626: Reset security should warn and re...
Content-Type: text/plain
Message-Id: <20160914171525.8E25BE07FE@git1-us-west.apache.org>
Date: Wed, 14 Sep 2016 17:15:25 +0000 (UTC)
archived-at: Wed, 14 Sep 2016 17:15:28 -0000

Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/151#discussion_r78792678
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java ---
    @@ -762,6 +764,17 @@ public void execute(final String[] args) {
           if (opts.resetSecurity) {
             AccumuloServerContext context = new AccumuloServerContext(new ServerConfigurationFactory(HdfsZooInstance.getInstance()));
             if (isInitialized(fs)) {
    +          if (!opts.forceResetSecurity) {
    +            String secret = acuConf.get(Property.INSTANCE_SECRET);
    +            ConsoleReader c = getConsoleReader();
    +            String userEnteredSecret = c.readLine("WARNING: This will remove all users from Accumulo! If you wish to proceed enter the instance secret: ", '*');
    +            if (userEnteredSecret != null && !secret.equals(userEnteredSecret)) {
    +              log.info("Aborted reset security: Instance secret did not match what is in accumulo-site.xml");
    +              return;
    +            }
    +            log.info("Beginning user initiated reset security on accumulo.");
    --- End diff --
    
    I added this log message since it is not clear what is going on in the output...
    2016-09-14 12:35:03,251 [conf.AccumuloConfiguration] INFO : Loaded class : org.apache.accumulo.server.security.handler.ZKAuthorizor
    2016-09-14 12:35:03,252 [conf.AccumuloConfiguration] INFO : Loaded class : org.apache.accumulo.server.security.handler.ZKAuthenticator
    2016-09-14 12:35:03,253 [conf.AccumuloConfiguration] INFO : Loaded class : org.apache.accumulo.server.security.handler.ZKPermHandler
    2016-09-14 12:35:03,508 [handler.ZKAuthenticator] INFO : Removed /accumulo/5a96e1b5-452b-4c35-ada7-cfa807cbd994/users/ from zookeeper


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---