Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-134-accumulo@git.apache.org>
In-Reply-To: <git-pr-134-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #134: ACCUMULO-4391 Source deepcopies cannot be used s...
Content-Type: text/plain
Message-Id: <20160906173601.B5FE8E01C1@git1-us-west.apache.org>
Date: Tue,  6 Sep 2016 17:36:01 +0000 (UTC)
archived-at: Tue, 06 Sep 2016 17:36:03 -0000

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/134#discussion_r77682253
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java ---
    @@ -146,9 +145,10 @@ public boolean markSupported() {
     
       @Override
       public void close() {
    -    // Invalidate the state of the stream.
    -    in = null;
    -    pos = end;
    -    mark = -1;
    +    // synchronize on the FSDataInputStream to ensure we are blocked if in the read method
    --- End diff --
    
    Maybe an `if (closed) return;` here since we have the volatile `closed` here already (and we can avoid grabbing the lock again).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---