accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <>
Subject [GitHub] accumulo pull request #159: ACCUMULO-1280: many changes for closing iterator...
Date Fri, 30 Sep 2016 16:59:21 GMT
GitHub user milleruntime opened a pull request:

    ACCUMULO-1280: many changes for closing iterators

    Looking for feedback on first round of changes and if there are more places close can
be called.
    - made SortedKeyValueIterator extend AutoCloseable
    - in SKVI - defined default close method so it is not required by implementations
    - in SKVI - defined default closeSafely to allow calling of close in a Java 8 stream
    - implemented close method where Iterator contained a SKVI source
    - modified Scanner and Compactor to utilize AutoCloseable and try-with-resources
    TODO: write test to verify close on wrapped iterators will propagate through

You can merge this pull request into a Git repository by running:

    $ git pull ACCUMULO-1280

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #159
commit e67eaa7b762632f5afc7f62e4b4a35a91ea7f658
Author: milleruntime <>
Date:   2016-09-22T14:31:24Z

    ACCUMULO-1280: many changes for closing iterators


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message