accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Josh Elser <josh.el...@gmail.com>
Subject Re: Review Request 51933: Improved BlockCache eviction policy
Date Fri, 16 Sep 2016 18:48:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51933/#review149238
-----------------------------------------------------------


Ship it!




You're the man, Ben. I was just going to fix them on commit :). Thanks for the updated patch.
I'm going to run a local test and then commit!

- Josh Elser


On Sept. 16, 2016, 6:02 p.m., Ben Manes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51933/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 6:02 p.m.)
> 
> 
> Review request for accumulo, Josh Elser and kturner.
> 
> 
> Bugs: ACCUMULO-4177
>     https://issues.apache.org/jira/browse/ACCUMULO-4177
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> TinyLFU-based BlockCache.
> 
> Algorithmic details provided in,
> http://highscalability.com/blog/2016/1/25/design-of-a-modern-cache.html
> 
> 
> Diffs
> -----
> 
>   assemble/pom.xml d0f14a9 
>   assemble/src/main/assemblies/component.xml 6fc6656 
>   core/pom.xml 44afddb 
>   core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java 4dfba68

>   core/src/main/java/org/apache/accumulo/core/conf/Property.java ede1c6f 
>   core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCache.java 094782d

>   core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/LruBlockCache.java
1beaccb 
>   core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/TinyLfuBlockCache.java
PRE-CREATION 
>   pom.xml 54e4a72 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 7751681

>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
089bd12 
> 
> Diff: https://reviews.apache.org/r/51933/diff/
> 
> 
> Testing
> -------
> 
> Basic build
> 
> 
> Thanks,
> 
> Ben Manes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message