accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Josh Elser <josh.el...@gmail.com>
Subject Re: Review Request 51933: Improved BlockCache eviction policy
Date Fri, 16 Sep 2016 16:24:11 GMT


> On Sept. 16, 2016, 1:16 a.m., Ben Manes wrote:
> > core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/TinyLfuBlockCache.java,
line 64
> > <https://reviews.apache.org/r/51933/diff/1/?file=1499136#file1499136line64>
> >
> >     Thanks. I called the class CaffeinatedBlockCache in HBase, but when porting
thought using the policy name was cleaner. I'll fix the HBase patch as well.

Thanks, Ben! Let me poke Keith over on JIRA. Otherwise, I'm content to merge this in today.


- Josh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51933/#review149160
-----------------------------------------------------------


On Sept. 16, 2016, 1:15 a.m., Ben Manes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51933/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 1:15 a.m.)
> 
> 
> Review request for accumulo, Josh Elser and kturner.
> 
> 
> Bugs: ACCUMULO-4177
>     https://issues.apache.org/jira/browse/ACCUMULO-4177
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> TinyLFU-based BlockCache.
> 
> Algorithmic details provided in,
> http://highscalability.com/blog/2016/1/25/design-of-a-modern-cache.html
> 
> 
> Diffs
> -----
> 
>   core/pom.xml 44afddb 
>   core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java 4dfba68

>   core/src/main/java/org/apache/accumulo/core/conf/Property.java ede1c6f 
>   core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCache.java 094782d

>   core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/LruBlockCache.java
1beaccb 
>   core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/TinyLfuBlockCache.java
PRE-CREATION 
>   minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java
8e35705 
>   pom.xml 54e4a72 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 7751681

>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
089bd12 
> 
> Diff: https://reviews.apache.org/r/51933/diff/
> 
> 
> Testing
> -------
> 
> Basic build
> 
> 
> Thanks,
> 
> Ben Manes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message