accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #152: ACCUMULO-4456 Make NotActiveServiceException an ...
Date Thu, 15 Sep 2016 21:45:37 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/152#discussion_r79066218
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java
---
    @@ -247,10 +252,14 @@ private void executeFateOperation(long opid, FateOperation op, List<ByteBuffer>
           try {
             client = MasterClient.getConnectionWithRetry(context);
             client.executeFateOperation(Tracer.traceInfo(), context.rpcCreds(), opid, op,
args, opts, autoCleanUp);
    -        break;
    +        return;
           } catch (TTransportException tte) {
             log.debug("Failed to call executeFateOperation(), retrying ... ", tte);
             sleepUninterruptibly(100, TimeUnit.MILLISECONDS);
    +      } catch (ThriftNotActiveServiceException e) {
    --- End diff --
    
    could almost use the new java convention where catch can list multiple exceptions, except
log msgs differ


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message