accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo issue #152: ACCUMULO-4456 Make NotActiveServiceException an RTE
Date Thu, 15 Sep 2016 14:50:08 GMT
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/152
  
    > Reading the docs, we would have been throwing a RuntimeException anyways (because
the checked exception is not capable of being thrown by our thrift RPC methods), so java would
have wrapped it in a UndeclaredThrowableException.
    
    I don't think this is 100% clear. What the code does at runtime would be equivalent to
what this patch changes (this patch is just more clear). The testing I did was unable to force
a failure, but I am not convinced if this is because I didn't figure out how to test it good
enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message