accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo issue #152: ACCUMULO-4456 Make NotActiveServiceException an RTE
Date Thu, 15 Sep 2016 14:46:51 GMT
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/152
  
    > have you tested this? Does it cause a retry?
    
    So, I tried to test this with via SIGSTOP'ing a client application, flipping the active
master, and then SIGCONT'ing the application and I was unable to get the client to actually
die without this change. Reading the docs, we would have been throwing a RuntimeException
anyways (because the checked exception is not capable of being thrown by our thrift RPC methods),
so java would have wrapped it in a UndeclaredThrowableException.
    
    > I suspect it will not cause a retry, but not completely sure
    
    Sounds like we'd have to make it a TException then? I went digging in Thrift code last
night trying to remember how this all works...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message