accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #151: ACCUMULO-3626: Reset security should warn and re...
Date Wed, 14 Sep 2016 17:14:13 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/151#discussion_r78792461
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java ---
    @@ -762,6 +764,17 @@ public void execute(final String[] args) {
           if (opts.resetSecurity) {
             AccumuloServerContext context = new AccumuloServerContext(new ServerConfigurationFactory(HdfsZooInstance.getInstance()));
             if (isInitialized(fs)) {
    +          if (!opts.forceResetSecurity) {
    +            String secret = acuConf.get(Property.INSTANCE_SECRET);
    +            ConsoleReader c = getConsoleReader();
    +            String userEnteredSecret = c.readLine("WARNING: This will remove all users
from Accumulo! If you wish to proceed enter the instance secret: ", '*');
    --- End diff --
    
    The prompt for the secret is similar to how GitHub asks you to type the name of the repo,
to be sure you really want to delete it. It's not a security check. The user running this
command already needs access to the server configuration file containing the secret. It's
just a sanity check. Instead of the secret, it could prompt for the instance name or ID.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message