accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #151: ACCUMULO-3626: Reset security should warn and re...
Date Wed, 14 Sep 2016 17:03:42 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/151#discussion_r78790611
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java ---
    @@ -762,6 +764,17 @@ public void execute(final String[] args) {
           if (opts.resetSecurity) {
             AccumuloServerContext context = new AccumuloServerContext(new ServerConfigurationFactory(HdfsZooInstance.getInstance()));
             if (isInitialized(fs)) {
    +          if (!opts.forceResetSecurity) {
    +            String secret = acuConf.get(Property.INSTANCE_SECRET);
    +            ConsoleReader c = getConsoleReader();
    +            String userEnteredSecret = c.readLine("WARNING: This will remove all users
from Accumulo! If you wish to proceed enter the instance secret: ", '*');
    --- End diff --
    
    > If you wish to proceed enter the instance secret
    
    Do we need to prompt for instance.secret instead of just a 'Y/N'? It's not apparent if
this is buying us anything. If someone can successfully re-init (permission wise), they have
the ability to get this value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message