accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewalch <...@git.apache.org>
Subject [GitHub] accumulo issue #147: ACCUMULO-2844 Removed 'slave' terminology
Date Thu, 08 Sep 2016 23:55:18 GMT
Github user mikewalch commented on the issue:

    https://github.com/apache/accumulo/pull/147
  
    > This sounds OK to me. We have a bit more leeway with a "real" major release than
I'm used to. I think I would be OK with error'ing out of the script in the case when only
the slaves file exists instead of just printing a message (catch it as early as possible and
push people to rename now instead of delaying).
    
    I like this approach.  I don't like falling back to 'slaves' file if 'tservers' does not
exist as all scripts that depend on 'tservers' need to do this.  A proper error message is
sufficient.  It's an easy fix.  I will add the following checks to the script and update the
PR:
    * First, fail if 'slaves' file exists and tell user to rename file to 'tservers' or remove
'slaves' if both exist.  This will prevent users from having both files.
    * Next, fail if 'tservers' does not exist


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message