accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #134: ACCUMULO-4391 Source deepcopies cannot be used s...
Date Thu, 08 Sep 2016 18:21:57 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/134#discussion_r78061546
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BCFile.java ---
    @@ -672,11 +674,23 @@ public BlockRegion getBlockRegion() {
           }
     
           public void finish() throws IOException {
    -        try {
    -          in.close();
    -        } finally {
    -          compressAlgo.returnDecompressor(decompressor);
    -          decompressor = null;
    +        if (!closed) {
    --- End diff --
    
    Whats the purpose of this double check?  Is it an optimization to avoid sync?  I suspect
that in the majority of cases where this is called, closed will be false.   Therefore this
double check will usually result in an extra round trip to memory (reading closed twice from
main memory) in the majority of cases. So this may slow down the majority case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message