accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From melrief <>
Subject [GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder
Date Fri, 02 Sep 2016 23:16:54 GMT
Github user melrief commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/accumulo/core/data/ ---
    @@ -51,6 +51,26 @@
       protected long timestamp;
       protected boolean deleted;
    +  /**
    +   * Create a {@link Key} builder.
    +   *
    +   * @param copyBytes
    +   *          if the bytes of the {@link Key} components should be copied
    +   * @return the builder at the {@link KeyBuilder.RowStep}
    +   */
    +  public static KeyBuilder.RowStep builder(boolean copyBytes) {
    --- End diff --
    Well, this `KeyBuilder` is strict while the previous implementation was lazy which means
that now I can't set the building option at the end. IMHO it's nice also in this way.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message