accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder
Date Fri, 02 Sep 2016 15:45:57 GMT
Github user keith-turner commented on the issue:

    https://github.com/apache/accumulo/pull/145
  
    @dhutchis even if a copy is done, if the API accepts ByteBuffers it can help avoid forcing
intermediate copies.  For example user has to copy ByteBuffer to byte array, pass that byte
array to KeyBuilder, and then KeyBuilder copies what it was passed.
    
    ByteBuffers are similar to input streams in that they have a position and reading from
it can change that position.  One decision we would have to make if we accept ByteBuffers
is if we want to change that position or not when reading.  If any other parts of API accept
ByteBuffer, would need to see what the behavior is.  We could possibly hold off on adding
ByteBuffer in this PR and open a separate issue to examine adding support for ByteBuffer the
API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message