accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder
Date Fri, 02 Sep 2016 01:47:34 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/145#discussion_r77282867
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/data/Key.java ---
    @@ -51,6 +51,26 @@
       protected long timestamp;
       protected boolean deleted;
     
    +  /**
    +   * Create a {@link Key} builder.
    +   *
    +   * @param copyBytes
    +   *          if the bytes of the {@link Key} components should be copied
    +   * @return the builder at the {@link KeyBuilder.RowStep}
    +   */
    +  public static KeyBuilder.RowStep builder(boolean copyBytes) {
    +    return new KeyBuilder.AbstractKeyBuilder(copyBytes);
    +  }
    +
    +  /**
    +   * Create a {@link Key} builder. Copy bytes defaults to true.
    +   *
    +   * @return the builder at the {@link KeyBuilder.RowStep}
    +   */
    +  public static KeyBuilder.RowStep builder() {
    --- End diff --
    
    Need to add `@since` tags to these two new methods in Key.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message