accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From melrief <...@git.apache.org>
Subject [GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder
Date Thu, 01 Sep 2016 22:12:55 GMT
Github user melrief commented on the issue:

    https://github.com/apache/accumulo/pull/145
  
    @keith-turner @dhutchis I pushed another commit with the design changes we discussed.
Now it is possible to write
    
    ```java
    Key.builder().row(new Text("row")).family(new byte[] { 1, 2, 3 }).qualifier("foo").build()
    ```
    
    to build a `Key`. There is still to decide about column family, qualifier and visibility
names and, while my point is that we should be consistent and keep the `column` before the
component name, I don't have a strong opinion about that.
    
    @joshelser I added two tests, one to check if the bytes are reused if `copyBytes` is `false`
and one to be sure that they are not if `copyBytes` is `true`.
    
    p.s. because a lot of people are commenting, I'm going to pile new commits and then squash
them at the end, if and when you decide to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message