accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From melrief <...@git.apache.org>
Subject [GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder
Date Thu, 01 Sep 2016 19:41:58 GMT
Github user melrief commented on the issue:

    https://github.com/apache/accumulo/pull/145
  
    @keith-turner Ok I'll add the possibility to use different data types. I wasn't aware
about this requirement and didn't design for it. I'll need some time.
    
    I have to disagree in removing the `column` from the column components. It may be easier
for who knows Accumulo but not for the new developer and being used to see `columnFamily`
or `colFam` everywhere would make this choice particularly difficult imho for no reasons.
    
    I don't understand why the `newBuilder()` method. What problem does it solve? The issue
on doing this is that `row` cannot be final in the `KeyBuilder` anymore and must default to
`null` when the `KeyBuilder` is built, which means that I have another `null` around for a
value that cannot be `null` and must be set. That's why I prefer to combine passing the `row`
and build the builder together, so I can use the constructor of the builder to set the `row`
asap and skip a `null` that eventually must be not `null`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message