Return-Path: <dev-return-15984-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 19E8E200B71
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 31 Aug 2016 21:38:01 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 182E4160AB4; Wed, 31 Aug 2016 19:38:01 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 5F45D160AA7
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 31 Aug 2016 21:38:00 +0200 (CEST)
Received: (qmail 82007 invoked by uid 500); 31 Aug 2016 19:37:59 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 81993 invoked by uid 99); 31 Aug 2016 19:37:59 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Aug 2016 19:37:59 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 10A96E01BD; Wed, 31 Aug 2016 19:37:59 +0000 (UTC)
From: adamjshook <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-143-accumulo@git.apache.org>
In-Reply-To: <git-pr-143-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #143: ACCUMULO-4428 Fix state of GC firstSeenDead map
Content-Type: text/plain
Message-Id: <20160831193759.10A96E01BD@git1-us-west.apache.org>
Date: Wed, 31 Aug 2016 19:37:59 +0000 (UTC)
archived-at: Wed, 31 Aug 2016 19:38:01 -0000

Github user adamjshook commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/143#discussion_r77057952
  
    --- Diff: test/src/test/java/org/apache/accumulo/test/functional/GarbageCollectorIT.java ---
    @@ -139,6 +150,52 @@ public void gcTest() throws Exception {
       }
     
       @Test
    +  public void gcDeleteDeadTServerWAL() throws Exception {
    +    // Kill GC process
    +    killMacGc();
    +
    +    // Create table and ingest data
    +    Connector c = getConnector();
    +    c.tableOperations().create("test_ingest");
    +    c.tableOperations().setProperty("test_ingest", Property.TABLE_SPLIT_THRESHOLD.getKey(), "5K");
    +    String tableId = getConnector().tableOperations().tableIdMap().get("test_ingest");
    +    TestIngest.Opts opts = new TestIngest.Opts();
    +    VerifyIngest.Opts vopts = new VerifyIngest.Opts();
    +    vopts.rows = opts.rows = 10000;
    +    vopts.cols = opts.cols = 1;
    +    opts.setPrincipal("root");
    +    vopts.setPrincipal("root");
    +    TestIngest.ingest(c, opts, new BatchWriterOpts());
    +
    +    // Test WAL log has been created
    +    List<String> walsBefore = getWALsForTableId(tableId);
    +    Assert.assertEquals("Should be one WAL", 1, walsBefore.size());
    +
    +    // Flush and check for no WAL logs
    +    c.tableOperations().flush("test_ingest", null, null, true);
    +    List<String> walsAfter = getWALsForTableId(tableId);
    +    Assert.assertEquals("Should be no WALs", 0, walsAfter.size());
    +
    +    // Validate WAL file still exists
    +    String walFile = walsBefore.get(0).split("\\|")[0].replaceFirst("file:///", "");
    +    File wf = new File(walFile);
    +    Assert.assertEquals("WAL file does not exist", true, wf.exists());
    +
    +    // Kill TServer and give it some time to die and master to rebalance
    +    killMacTServer();
    --- End diff --
    
    I like your changes and the test is running for me as well.  Thank you for helping push this through.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---