Return-Path: <dev-return-15935-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id D38F4200B80
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 31 Aug 2016 02:23:35 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id D1651160AC6; Wed, 31 Aug 2016 00:23:35 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 4BA7F160ABA
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 31 Aug 2016 02:23:35 +0200 (CEST)
Received: (qmail 50422 invoked by uid 500); 31 Aug 2016 00:23:34 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 50405 invoked by uid 99); 31 Aug 2016 00:23:34 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Aug 2016 00:23:34 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 2271DE00DB; Wed, 31 Aug 2016 00:23:34 +0000 (UTC)
From: ctubbsii <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-144-accumulo@git.apache.org>
In-Reply-To: <git-pr-144-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #144: ACCUMULO-4423 Annotate integration tests with ca...
Content-Type: text/plain
Message-Id: <20160831002334.2271DE00DB@git1-us-west.apache.org>
Date: Wed, 31 Aug 2016 00:23:34 +0000 (UTC)
archived-at: Wed, 31 Aug 2016 00:23:36 -0000

Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/144#discussion_r76904810
  
    --- Diff: pom.xml ---
    @@ -115,6 +115,10 @@
         <url>https://builds.apache.org/view/A-D/view/Accumulo/</url>
       </ciManagement>
       <properties>
    +    <accumulo.anyClusterTests>org.apache.accumulo.test.categories.AnyClusterTest</accumulo.anyClusterTests>
    +    <accumulo.integrationTestsExcludedGroups />
    +    <accumulo.integrationTestsGroups>${accumulo.anyClusterTests},${accumulo.miniclusterTests}</accumulo.integrationTestsGroups>
    --- End diff --
    
    I'd suggest shortening these property names to `accumulo.it.groups` and `accumulo.it.excludeGroups` to more closely match the user property names in the failsafe plugin, but without removing the accumulo-failsafe-specific context you've added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---