Return-Path: <dev-return-15916-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id E8996200B76
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 30 Aug 2016 23:57:35 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id E709A160ABA; Tue, 30 Aug 2016 21:57:35 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 3A682160AAF
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 30 Aug 2016 23:57:35 +0200 (CEST)
Received: (qmail 62860 invoked by uid 500); 30 Aug 2016 21:57:34 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 62845 invoked by uid 99); 30 Aug 2016 21:57:33 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Aug 2016 21:57:33 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D3E6FDFF8E; Tue, 30 Aug 2016 21:57:33 +0000 (UTC)
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-144-accumulo@git.apache.org>
In-Reply-To: <git-pr-144-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #144: ACCUMULO-4423 Annotate integration tests with ca...
Content-Type: text/plain
Message-Id: <20160830215733.D3E6FDFF8E@git1-us-west.apache.org>
Date: Tue, 30 Aug 2016 21:57:33 +0000 (UTC)
archived-at: Tue, 30 Aug 2016 21:57:36 -0000

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/144#discussion_r76887503
  
    --- Diff: test/pom.xml ---
    @@ -273,5 +275,41 @@
             </dependency>
           </dependencies>
         </profile>
    +    <profile>
    +      <id>minicluster-unit-tests</id>
    +      <properties>
    +        <accumulo.skipMiniClusterInFailsafe>true</accumulo.skipMiniClusterInFailsafe>
    +      </properties>
    +      <build>
    +        <pluginManagement>
    +          <plugins>
    +            <plugin>
    +              <groupId>org.apache.maven.plugins</groupId>
    +              <artifactId>maven-surefire-plugin</artifactId>
    +              <executions>
    +                <!-- Adds an execution for the minicluster-only tests at the test phase -->
    +                <execution>
    +                  <id>run-minicluster-unit-tests</id>
    +                  <goals>
    +                    <goal>test</goal>
    +                  </goals>
    +                  <phase>test</phase>
    +                  <configuration>
    +                    <groups>${accumulo.miniclusterTests}</groups>
    +                    <!-- Includes still limit the search-space for groups -->
    +                    <includes>
    +                      <include>**/Test*.java</include>
    +                      <include>**/*Test.java</include>
    +                      <include>**/*TestCase.java</include>
    +                      <include>**/*IT.java</include>
    --- End diff --
    
    Miss that part of my goal from JIRA? :)
    
    One of the goals I had in the separation of these test cases was to allow all "encapsulated" tests to be run at unit-test time. This leaves only the tests capable of running against a real cluster at integration-test time. Makes the separation of "embedded tests" and "cluster tests" easier to work around in automated build/test systems like Jenkins.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---