Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-134-accumulo@git.apache.org>
In-Reply-To: <git-pr-134-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #134: ACCUMULO-4391 Source deepcopies cannot be used s...
Content-Type: text/plain
Message-Id: <20160803153705.BF53CE3839@git1-us-west.apache.org>
Date: Wed,  3 Aug 2016 15:37:05 +0000 (UTC)
archived-at: Wed, 03 Aug 2016 15:37:07 -0000

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/134#discussion_r73361217
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BCFile.java ---
    @@ -672,11 +672,24 @@ public BlockRegion getBlockRegion() {
           }
     
           public void finish() throws IOException {
    -        try {
    -          in.close();
    -        } finally {
    -          compressAlgo.returnDecompressor(decompressor);
    -          decompressor = null;
    +        final InputStream inLocal = in;
    +        if (inLocal != null) {
    +          synchronized (inLocal) {
    +            if (in != null) {
    +              try {
    +                in.close();
    +              } finally {
    +                in = null;
    --- End diff --
    
    Could also use a boolean to track closed here and avoid the inLocal and double check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---