accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phrocker <...@git.apache.org>
Subject [GitHub] accumulo pull request #140: ACCUMULO-4419: Change how compression delegation...
Date Mon, 22 Aug 2016 16:57:00 GMT
GitHub user phrocker opened a pull request:

    https://github.com/apache/accumulo/pull/140

    ACCUMULO-4419: Change how compression delegation works

    This commit includes A compression pool not based on CodecPool,
    a default factory that does no pooling. Changes are also
    in place that will allow us to better control some aspects of
    Compression within the tserver
    
    These are early changes, so I'm soliciting feedback before I continue. My main concerns
are:
    
    Do we really need the ability to trim the codec pool and the other features that commons-pool
provides.
    Does this really need to be configurable? I believe so as we are using this.
    What additional tests should I add? I'm working a few more but if there ideas I would
gladly ignore them ;)
    Should I make anything else configurable for this first pass? 
    When scrolling through the changes there are some comments I'd like to see so I'm going
to update comments. If you have any input I'm all ears. 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/accumulo-1 ACCUMULO-4419

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #140
    
----
commit c3fd9984aa63dfd64b95b67955d9a967375cc464
Author: phrocker <marc.parisi@gmail.com>
Date:   2016-08-05T12:15:30Z

    ACCUMULO-4419: Change how compression delegation works
    
    This commit includes A compression pool not based on CodecPool,
    a default factory that does no pooling. Changes are also
    in place that will allow us to better control some aspects of
    Compression within the tserver

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message