accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #143: ACCUMULO-4428 Fix state of GC firstSeenDead map
Date Wed, 31 Aug 2016 19:11:01 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/143#discussion_r77053244
  
    --- Diff: test/src/test/java/org/apache/accumulo/test/functional/GarbageCollectorIT.java
---
    @@ -139,6 +150,52 @@ public void gcTest() throws Exception {
       }
     
       @Test
    +  public void gcDeleteDeadTServerWAL() throws Exception {
    +    // Kill GC process
    +    killMacGc();
    +
    +    // Create table and ingest data
    +    Connector c = getConnector();
    +    c.tableOperations().create("test_ingest");
    +    c.tableOperations().setProperty("test_ingest", Property.TABLE_SPLIT_THRESHOLD.getKey(),
"5K");
    +    String tableId = getConnector().tableOperations().tableIdMap().get("test_ingest");
    +    TestIngest.Opts opts = new TestIngest.Opts();
    +    VerifyIngest.Opts vopts = new VerifyIngest.Opts();
    +    vopts.rows = opts.rows = 10000;
    +    vopts.cols = opts.cols = 1;
    +    opts.setPrincipal("root");
    +    vopts.setPrincipal("root");
    +    TestIngest.ingest(c, opts, new BatchWriterOpts());
    +
    +    // Test WAL log has been created
    +    List<String> walsBefore = getWALsForTableId(tableId);
    +    Assert.assertEquals("Should be one WAL", 1, walsBefore.size());
    +
    +    // Flush and check for no WAL logs
    +    c.tableOperations().flush("test_ingest", null, null, true);
    +    List<String> walsAfter = getWALsForTableId(tableId);
    +    Assert.assertEquals("Should be no WALs", 0, walsAfter.size());
    +
    +    // Validate WAL file still exists
    +    String walFile = walsBefore.get(0).split("\\|")[0].replaceFirst("file:///", "");
    +    File wf = new File(walFile);
    +    Assert.assertEquals("WAL file does not exist", true, wf.exists());
    +
    +    // Kill TServer and give it some time to die and master to rebalance
    +    killMacTServer();
    --- End diff --
    
    I think this is also prone to errors. We don't know if we killed the tserver which had
a WAL (possible that only one of the two tserver had a WAL and we killed the one that had
none). I think changing this to restart both would work so we're certain the old WAL will
be cleaned up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message