accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #143: ACCUMULO-4428 Fix state of GC firstSeenDead map
Date Wed, 31 Aug 2016 17:36:44 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/143#discussion_r77034759
  
    --- Diff: server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java ---
    @@ -530,6 +531,9 @@ private void run() {
     
         ProbabilitySampler sampler = new ProbabilitySampler(getConfiguration().getFraction(Property.GC_TRACE_PERCENT));
     
    +    // Map of tserver -> timestamp, used by the GCWriteAheadLogs to track state of
when a tablet server went down
    +    Map<HostAndPort, Long> firstSeenDead = new HashMap<>();
    --- End diff --
    
    Nit: let's make this `final` to make sure that we don't ever accidentally overwrite the
variable and end up with the same bug in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message