accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #144: ACCUMULO-4423 Annotate integration tests with ca...
Date Wed, 31 Aug 2016 03:47:22 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/144#discussion_r76920439
  
    --- Diff: pom.xml ---
    @@ -1399,5 +1407,19 @@
             </pluginManagement>
           </build>
         </profile>
    +    <profile>
    --- End diff --
    
    I don't follow that reasoning. Could you clarify?
    
    I was referring to some technical-based justification that emphasizes the importance of
these presets over other potential ones which could conceivably apply to all builders of the
project. If you mean to suggest that Dima's individual use case has these particular preferences,
that doesn't seem like a strong justification for me. We can't reasonably characterize everybody's
presets into our POM, after all (unfortunate as that may be), and I would advise users with
particular presets preferences to create individualized profiles in their settings.xml file,
because that's what that's for.... that's how Maven is intended to work: pom.xml for universal
settings, and settings.xml for individual preferences.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message