accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #144: ACCUMULO-4423 Annotate integration tests with ca...
Date Wed, 31 Aug 2016 03:27:29 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/144#discussion_r76919026
  
    --- Diff: pom.xml ---
    @@ -115,6 +115,10 @@
         <url>https://builds.apache.org/view/A-D/view/Accumulo/</url>
       </ciManagement>
       <properties>
    +    <accumulo.anyClusterTests>org.apache.accumulo.test.categories.AnyClusterTest</accumulo.anyClusterTests>
    +    <accumulo.integrationTestsExcludedGroups />
    +    <accumulo.integrationTestsGroups>${accumulo.anyClusterTests},${accumulo.miniclusterTests}</accumulo.integrationTestsGroups>
    +    <accumulo.miniclusterTests>org.apache.accumulo.test.categories.MiniClusterOnlyTest</accumulo.miniclusterTests>
    --- End diff --
    
    I guess that would be useful if these particular category aliases stood out above others...
and in particular if we expect them to move around due to refactors. Otherwise, it's a class
name inside a property inside a property, and I think it'd be a bit more intuitive to have
the class directly in the property.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message