accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #144: ACCUMULO-4423 Annotate integration tests with ca...
Date Wed, 31 Aug 2016 03:23:55 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/144#discussion_r76918677
  
    --- Diff: pom.xml ---
    @@ -1399,5 +1407,19 @@
             </pluginManagement>
           </build>
         </profile>
    +    <profile>
    --- End diff --
    
    Not a particular burden. It's just arbitrary. Why profiles for these particular combination
of groups/excludes? Why not others? When we add more categories (which we almost certainly
will), how much sense will it make to preserve a single distinct combination, but others?
    
    I just don't see much value in establishing these particular presets, and it will be confusing
as more categories are added why this particular subset of possible presets are added as convenience
profiles for everybody.
    
    If there's a good reason why these particular presets are useful, above all other potential
future combinations of categories, for now and in the future, then I'd say we'd have a strong
reason to pre-define them. Otherwise, I think they're better omitted, and not singled out
in the docs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message