accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #144: ACCUMULO-4423 Annotate integration tests with ca...
Date Wed, 31 Aug 2016 02:46:42 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/144#discussion_r76916290
  
    --- Diff: pom.xml ---
    @@ -1006,6 +1010,10 @@
                   <goal>integration-test</goal>
                   <goal>verify</goal>
                 </goals>
    +            <configuration>
    +              <excludeGroups>${accumulo.integrationTestsExcludedGroups}</excludeGroups>
    +              <groups>${accumulo.integrationTestsGroups}</groups>
    +            </configuration>
    --- End diff --
    
    > Since you've added this indirection for failsafe, would it make sense to also add
this to surefire
    
    Presently we don't have any groups for tests we run through surefire though.
    
    > Unfortunately, surefire and failsafe use the same user properties for these
    
    I think this is also a good reason to have the profiles.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message