accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #144: ACCUMULO-4423 Annotate integration tests with ca...
Date Wed, 31 Aug 2016 00:35:52 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/144#discussion_r76905938
  
    --- Diff: pom.xml ---
    @@ -1006,6 +1010,10 @@
                   <goal>integration-test</goal>
                   <goal>verify</goal>
                 </goals>
    +            <configuration>
    +              <excludeGroups>${accumulo.integrationTestsExcludedGroups}</excludeGroups>
    +              <groups>${accumulo.integrationTestsGroups}</groups>
    +            </configuration>
    --- End diff --
    
    This is a great way to add indirection to the properties, so users can control failsafe
directly, without affecting surefire. Unfortunately, surefire and failsafe use the same user
properties for these, so we must add this indirection ourselves (I lament that surefire doesn't
use `tests.groups` and `tests.excludeGroups` and failsafe doesn't use `it.groups` and `it.excludeGroups`).
    
    Since you've added this indirection for failsafe, would it make sense to also add this
to surefire? Right now, the way to control surefire is with the `groups` and `excludeGroups`
properties respected by the plugin. That will override these settings for failsafe, too, and
that's probably not desirable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message