accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #144: ACCUMULO-4423 Annotate integration tests with ca...
Date Wed, 31 Aug 2016 00:30:31 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/144#discussion_r76905452
  
    --- Diff: test/src/test/java/org/apache/accumulo/harness/SharedMiniClusterIT.java ---
    @@ -48,6 +50,7 @@
      * a method annotated with the {@link org.junit.BeforeClass} JUnit annotation and {@link
#stopMiniCluster()} in a method annotated with the
      * {@link org.junit.AfterClass} JUnit annotation.
      */
    +@Category(MiniClusterOnlyTest.class)
    --- End diff --
    
    It surprises me that these annotations would be inherited. I know annotations aren't inherited
in Java, but maybe JUnit handles that itself. I assume you've tested this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message