accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #144: ACCUMULO-4423 Annotate integration tests with ca...
Date Tue, 30 Aug 2016 22:16:01 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/144#discussion_r76890217
  
    --- Diff: pom.xml ---
    @@ -1001,11 +1004,26 @@
             <artifactId>maven-failsafe-plugin</artifactId>
             <executions>
               <execution>
    -            <id>run-integration-tests</id>
    +            <id>run-minicluster-integration-tests</id>
                 <goals>
                   <goal>integration-test</goal>
                   <goal>verify</goal>
                 </goals>
    +            <configuration>
    +              <skip>${accumulo.skipMiniClusterInFailsafe}</skip>
    +              <groups>${accumulo.miniclusterTests}</groups>
    +            </configuration>
    +          </execution>
    +          <execution>
    --- End diff --
    
    If a user overrides the categories by setting the documented surefire/failsafe properties,
`groups` and `excludedGroups`, it will completely override all of the settings you've added
to these executions. They will get two executions of the same tests, taking twice as long,
as the second execution will clobber the reports from the first, before the verify phase.
    
    I can try to explain more later, if this isn't clear.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message