accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #144: ACCUMULO-4423 Annotate integration tests with ca...
Date Tue, 30 Aug 2016 22:04:56 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/144#discussion_r76888657
  
    --- Diff: pom.xml ---
    @@ -1001,11 +1004,26 @@
             <artifactId>maven-failsafe-plugin</artifactId>
             <executions>
               <execution>
    -            <id>run-integration-tests</id>
    +            <id>run-minicluster-integration-tests</id>
                 <goals>
                   <goal>integration-test</goal>
                   <goal>verify</goal>
                 </goals>
    +            <configuration>
    +              <skip>${accumulo.skipMiniClusterInFailsafe}</skip>
    +              <groups>${accumulo.miniclusterTests}</groups>
    +            </configuration>
    +          </execution>
    +          <execution>
    --- End diff --
    
    Ah, that may be the case, but multiple annotations is already problematic. I ran into
an issue in master doing this with the perf tests. Suddenly, perf tests are being run when
trying to run just the minicluster tests. My present approach is to only have one category
per test presently (and override if necessary as some tests do).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message