accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #144: ACCUMULO-4423 Annotate integration tests with ca...
Date Tue, 30 Aug 2016 21:57:33 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/144#discussion_r76887503
  
    --- Diff: test/pom.xml ---
    @@ -273,5 +275,41 @@
             </dependency>
           </dependencies>
         </profile>
    +    <profile>
    +      <id>minicluster-unit-tests</id>
    +      <properties>
    +        <accumulo.skipMiniClusterInFailsafe>true</accumulo.skipMiniClusterInFailsafe>
    +      </properties>
    +      <build>
    +        <pluginManagement>
    +          <plugins>
    +            <plugin>
    +              <groupId>org.apache.maven.plugins</groupId>
    +              <artifactId>maven-surefire-plugin</artifactId>
    +              <executions>
    +                <!-- Adds an execution for the minicluster-only tests at the test
phase -->
    +                <execution>
    +                  <id>run-minicluster-unit-tests</id>
    +                  <goals>
    +                    <goal>test</goal>
    +                  </goals>
    +                  <phase>test</phase>
    +                  <configuration>
    +                    <groups>${accumulo.miniclusterTests}</groups>
    +                    <!-- Includes still limit the search-space for groups -->
    +                    <includes>
    +                      <include>**/Test*.java</include>
    +                      <include>**/*Test.java</include>
    +                      <include>**/*TestCase.java</include>
    +                      <include>**/*IT.java</include>
    --- End diff --
    
    Miss that part of my goal from JIRA? :)
    
    One of the goals I had in the separation of these test cases was to allow all "encapsulated"
tests to be run at unit-test time. This leaves only the tests capable of running against a
real cluster at integration-test time. Makes the separation of "embedded tests" and "cluster
tests" easier to work around in automated build/test systems like Jenkins.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message