accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #144: ACCUMULO-4423 Annotate integration tests with ca...
Date Tue, 30 Aug 2016 21:55:47 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/144#discussion_r76887242
  
    --- Diff: pom.xml ---
    @@ -1001,11 +1004,26 @@
             <artifactId>maven-failsafe-plugin</artifactId>
             <executions>
               <execution>
    -            <id>run-integration-tests</id>
    +            <id>run-minicluster-integration-tests</id>
                 <goals>
                   <goal>integration-test</goal>
                   <goal>verify</goal>
                 </goals>
    +            <configuration>
    +              <skip>${accumulo.skipMiniClusterInFailsafe}</skip>
    +              <groups>${accumulo.miniclusterTests}</groups>
    +            </configuration>
    +          </execution>
    +          <execution>
    --- End diff --
    
    Yes, they would be sharing a log directory, but aren't the contents going to be unique
(e.g. class names are stil unique).
    
    > How does failsafe match up the two different integration-test mojo outputs with their
corresponding verify mojo work if both execute?
    
    I.. don't understand the question :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message