accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phrocker <...@git.apache.org>
Subject [GitHub] accumulo pull request #140: ACCUMULO-4419: Change how compression delegation...
Date Tue, 30 Aug 2016 21:34:51 GMT
Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/140#discussion_r76883729
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java ---
    @@ -349,7 +349,18 @@
           "Memory to provide to batchwriter to replay mutations for replication"),
       TSERV_ASSIGNMENT_MAXCONCURRENT("tserver.assignment.concurrent.max", "2", PropertyType.COUNT,
           "The number of threads available to load tablets. Recoveries are still performed
serially."),
    -
    +  TSERV_COMPRESSOR_FACTORY("tserver.compressor.factory.class", "org.apache.accumulo.core.file.rfile.bcfile.codec.CompressorFactory",
PropertyType.CLASSNAME,
    +      "Tablet Server configuration for the compressor factory that will be used when
requesting compressors."),
    +  TSERV_COMPRESSOR_IN_BUFFER("tserver.compressor.factory.input.buffer.size", "1K", PropertyType.MEMORY,
    +      "Tablet Server configuration for the compressor factory that adjusts the input
buffer size. Zero uses the full compression block size."),
    +  TSERV_COMPRESSOR_OUT_BUFFER("tserver.compressor.factory.output.buffer.size", "1K",
PropertyType.MEMORY,
    +      "Tablet Server configuration for the compressor factory that adjusts the output
buffer size. Default uses the full compression block size."),
    +  TSERV_COMPRESSOR_POOL_IDLE("tserver.compressor.pool.max.idle", "25", PropertyType.COUNT,
    --- End diff --
    
    It was. I think as Josh alluded to we need some more proof testing here. Apparently I
used Commons pool 1 which was an oversight....so switching to 2 and performance tests is needed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message