accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #135: ACCUMULO-1787: created TwoTierCompactionStrategy...
Date Tue, 30 Aug 2016 15:31:15 GMT
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/135#discussion_r76819411
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/TwoTierCompactionStrategy.java
---
    @@ -61,6 +64,18 @@ public void verifyRequiredProperties(Object... objectsToVerify) throws
IllegalAr
         }
       }
     
    +  /**
    +   * Calculates the total size of input files in the compaction plan
    +   */
    +  private Long calculateTotalSize(MajorCompactionRequest request, CompactionPlan plan)
{
    +    long totalSize = 0;
    +    Map<FileRef,DataFileValue> allFiles = request.getFiles();
    +    for (FileRef fileRef : plan.inputFiles) {
    --- End diff --
    
    They should be at this point since this class extends DefaultCompactionStrategy and calls
super.getCompactionPlan() to get the plan. If you look at DefaultCompactionStrategy.findMapFilesToCompact()
it creates the plan.inputFiles from the request...
    `    for (Entry<FileRef,DataFileValue> entry : request.getFiles().entrySet()) {
          candidateFiles.add(new CompactionFile(entry.getKey(), entry.getValue().getSize()));
        }`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message