accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #135: ACCUMULO-1787: created TwoTierCompactionStrategy...
Date Mon, 29 Aug 2016 21:56:28 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/135#discussion_r76695415
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/TwoTierCompactionStrategy.java
---
    @@ -61,6 +64,18 @@ public void verifyRequiredProperties(Object... objectsToVerify) throws
IllegalAr
         }
       }
     
    +  /**
    +   * Calculates the total size of input files in the compaction plan
    +   */
    +  private Long calculateTotalSize(MajorCompactionRequest request, CompactionPlan plan)
{
    +    long totalSize = 0;
    +    Map<FileRef,DataFileValue> allFiles = request.getFiles();
    +    for (FileRef fileRef : plan.inputFiles) {
    --- End diff --
    
    I am wondering if you could iterate over `request.getFiles().values()`?  Are the keys
of request.getFiles() and plan.inputFiles the same?  I am not sure, would have to look at
the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message