accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjwall <...@git.apache.org>
Subject [GitHub] accumulo pull request #143: ACCUMULO-4428 Fix state of GC firstSeenDead map
Date Mon, 29 Aug 2016 21:43:35 GMT
Github user mjwall commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/143#discussion_r76693414
  
    --- Diff: server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java
---
    @@ -80,10 +80,10 @@
     
     public class GarbageCollectWriteAheadLogs {
       private static final Logger log = LoggerFactory.getLogger(GarbageCollectWriteAheadLogs.class);
    +  private static final Map<HostAndPort,Long> firstSeenDead = new HashMap<HostAndPort,Long>();
     
       private final AccumuloServerContext context;
       private final VolumeManager fs;
    -  private final Map<HostAndPort,Long> firstSeenDead = new HashMap<HostAndPort,Long>();
    --- End diff --
    
    I tried really hard to make an integration test showed the initial error reported in ACCUMULO-4157,
but it was too hard to control the moving parts make a WAL be deleted before it should have
been.  My work is [here](https://github.com/mjwall/accumulo/blob/62b0e879cbc00773d1fbdbada9d696d42ecd6531/test/src/test/java/org/apache/accumulo/test/functional/GarbageCollectWriteAheadLogsIT.java)
if you want to look.  It is ugly and didn't work, but maybe will give you starting point.
 Or maybe it is just an example of what not to do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message