accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo issue #143: ACCUMULO-4428 Fix state of GC firstSeenDead map
Date Mon, 29 Aug 2016 21:26:26 GMT
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/143
  
    Thanks for the PR, Adam!
    
    > I'm open to other fixes like pulling the GCWAL out of the while (true) loop, but
I wasn't sure if things like the return value of isUsingTrash or the FileSystem could change
during runtime.
    
    I don't think the FileSystem instance will ever change (could be mistaken though), but
the trash-boolean might. Could easily push those into arguments on the `run()` method for
`GCWAL`. I think that would be a cleaner approach than introducing the static state.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message