accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adamjshook <...@git.apache.org>
Subject [GitHub] accumulo pull request #143: ACCUMULO-4428 Fix state of GC firstSeenDead map
Date Mon, 29 Aug 2016 21:24:05 GMT
Github user adamjshook commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/143#discussion_r76690207
  
    --- Diff: server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java
---
    @@ -80,10 +80,10 @@
     
     public class GarbageCollectWriteAheadLogs {
       private static final Logger log = LoggerFactory.getLogger(GarbageCollectWriteAheadLogs.class);
    +  private static final Map<HostAndPort,Long> firstSeenDead = new HashMap<HostAndPort,Long>();
     
       private final AccumuloServerContext context;
       private final VolumeManager fs;
    -  private final Map<HostAndPort,Long> firstSeenDead = new HashMap<HostAndPort,Long>();
    --- End diff --
    
    Yeah, I was looking at the test cases to see about implementing something to expose the
bug and ensure it gets fixed, but I am at a loss (I've spent WAY more time using Accumulo
than digging through the source code).
    
    I tested it locally by:
    
    - Starting single-instance Accumulo
    - Starting another TServer
    - Inserting data
    - Killing the other tserver
    - Watch the GC add it to the map
    - Watch the next GC cycle delete the WAL file (I configured it to have a short delete
time)
    - Started the other tserver and add more data
    - Kill the other tserver and watch the GC add it to the map on the first cycle, then delete
it next cycle



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message