accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phrocker <...@git.apache.org>
Subject [GitHub] accumulo pull request #143: ACCUMULO-4428 Fix state of GC firstSeenDead map
Date Mon, 29 Aug 2016 21:20:29 GMT
Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/143#discussion_r76689634
  
    --- Diff: server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java
---
    @@ -80,10 +80,10 @@
     
     public class GarbageCollectWriteAheadLogs {
       private static final Logger log = LoggerFactory.getLogger(GarbageCollectWriteAheadLogs.class);
    +  private static final Map<HostAndPort,Long> firstSeenDead = new HashMap<HostAndPort,Long>();
     
       private final AccumuloServerContext context;
       private final VolumeManager fs;
    -  private final Map<HostAndPort,Long> firstSeenDead = new HashMap<HostAndPort,Long>();
    --- End diff --
    
    I'm curious if there are tests to ensure that state is eventually cleared if the tserver
comes back online. I'd be concerned about rollover if the tserver came back. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message