accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjwall <...@git.apache.org>
Subject [GitHub] accumulo pull request #136: Accumulo 2971: improvements to ChangeSecret Tool
Date Thu, 04 Aug 2016 21:22:20 GMT
Github user mjwall commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/136#discussion_r73605280
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/util/ChangeSecret.java
---
    @@ -61,14 +64,16 @@ public static void main(String[] args) throws Exception {
         opts.parseArgs(ChangeSecret.class.getName(), argsList.toArray(new String[0]));
         VolumeManager fs = VolumeManagerImpl.get();
         Instance inst = opts.getInstance();
    -    if (!verifyAccumuloIsDown(inst, opts.oldPass))
    -      System.exit(-1);
    -    String instanceId = rewriteZooKeeperInstance(inst, opts.oldPass, opts.newPass);
    -    updateHdfs(fs, inst, instanceId);
    +    verifyAccumuloIsDown(inst, opts.oldPass);
    +    System.exit(1);
    --- End diff --
    
    This should be removed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message