accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjwall <...@git.apache.org>
Subject [GitHub] accumulo issue #136: Accumulo 2971: improvements to ChangeSecret Tool
Date Thu, 04 Aug 2016 21:22:00 GMT
Github user mjwall commented on the issue:

    https://github.com/apache/accumulo/pull/136
  
    @milleruntime can you make this against the 1.8 branch?  I cherry picked your commits,
but had to make a argument final. You should see it when you go to 1.8.
    
    Couple of comments:
    - You left a System.exit(1) in the main method.  I'll annotate the diff
    - When I removed that System exit, I got the following
    `2016-08-04 17:14:43,704 [start.Main] ERROR: Thread 'org.apache.accumulo.server.util.ChangeSecret'
died.
    java.lang.NoSuchMethodError: org.apache.hadoop.fs.FileSystem.access(Lorg/apache/hadoop/fs/Path;Lorg/apache/hadoop/fs/permission/FsAction;)V
    	at org.apache.accumulo.server.util.ChangeSecret.verifyHdfsWritePermission(ChangeSecret.java:172)
    	at org.apache.accumulo.server.util.ChangeSecret.main(ChangeSecret.java:68)
    	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    	at java.lang.reflect.Method.invoke(Method.java:606)
    	at org.apache.accumulo.start.Main$2.run(Main.java:157)
    	at java.lang.Thread.run(Thread.java:745)
    `  Probably because I was using hadoop 2.4.1 though.  I was hoping to see the message
in the IOException in verifyHdfsWritePermission.
    - Can we move the verifyAccumuloIsDown and verifyHdfsWritePermission above the opts parsing.
 There is no need to prompt for the instance secret if we know it is going to fail.
    
    I am going to move this to 1.8.1, it can be a bug fix.  I was thinking it changed behavior
and was trying to push it into 1.8.0.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message