accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ivakegg <...@git.apache.org>
Subject [GitHub] accumulo pull request #134: ACCUMULO-4391 Source deepcopies cannot be used s...
Date Wed, 03 Aug 2016 17:29:34 GMT
Github user ivakegg commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/134#discussion_r73380337
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java
---
    @@ -149,9 +149,13 @@ public boolean markSupported() {
     
       @Override
       public void close() {
    -    // Invalidate the state of the stream.
    -    in = null;
    -    pos = end;
    -    mark = -1;
    +    final FSDataInputStream inLocal = in;
    +    if (inLocal != null) {
    +      // synchronize on the FSDataInputStream to ensure we block closing if in the read
method
    +      synchronized (inLocal) {
    +        // Invalidate the state of the stream.
    +        in = null;
    --- End diff --
    
    I like it, shall do


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message